MOS annotation: calculate Cgg as Cgg+Cgsol+Cgdol; MOS+BIP annotation improved to show NaN if the associated parameter is not saved #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fath
requested review from
KrzysztofHerman and
sergeiandreyev
as code owners
…improved to show NaN if the associated parameter is not saved Signed-off-by: Patrick Fath <p_fath@hotmail.com>
p-fath
force-pushed
the
improve_mos_annotation
branch
from
a98e299 to
373723d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOS annotation: calculate Cgg as Cgg+Cgsol+Cgdol; MOS+BIP annotation improved to show NaN if the associated parameter is not saved.
Cgg was updated to fit the gmID tables. This are the cap computations when generating the sizing LUTs. The overlap caps are added to Cgg, but extracted from Cgd and Cgs. Similar for Cdd and Css.
cgg = np.reshape(df['cgg'].values, dims, order='C')
+ np.reshape(df['cgdol'].values, dims, order='C')
+ np.reshape(df['cgsol'].values, dims, order='C')
cgb = -np.reshape(df['cgb'].values, dims, order='C')
cgd = -np.reshape(df['cgd'].values, dims, order='C')
+ np.reshape(df['cgdol'].values, dims, order='C')
cgs = -np.reshape(df['cgs'].values, dims, order='C')
+ np.reshape(df['cgsol'].values, dims, order='C')
cdd = np.reshape(df['cdd'].values, dims, order='C')
+ np.reshape(df['cjd'].values, dims, order='C')
+ np.reshape(df['cgdol'].values, dims, order='C')
css = np.reshape(df['css'].values, dims, order='C')
+ np.reshape(df['cjs'].values, dims, order='C')
+ np.reshape(df['cgsol'].values, dims, order='C')
MOS:
BIP:
