Fixing LVS problems: Adjusted symbols rppd, rsil, rhigh, cap_cmim and npn13g2 #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fath
requested review from
KrzysztofHerman and
sergeiandreyev
as code owners
p-fath
force-pushed
the
res_lvs_fix
branch
2 times, most recently
from
a5a4088 to
7a244a8
Compare
p-fath
changed the title
…ipt still has to be updated to handel bulk node on resistor! Signed-off-by: Patrick Fath <p_fath@hotmail.com>
Signed-off-by: Patrick Fath <p_fath@hotmail.com>
…ipt still has to be updated to handel bulk node on resistor!; adjusted hbt and cap_mim to remove spiceprefix in LVS_format Signed-off-by: Patrick Fath <p_fath@hotmail.com>
d-m-bailey
reviewed
Oct 1, 2025
Contributor
d-m-bailey
left a comment
d-m-bailey
left a comment
There was a problem hiding this comment.
As mentioned in other reviews, the changes to the lvs_format here will require the users to name devices with the correct prefix: Q for npn and C for caps.
Contributor
@KrzysztofHerman, is it ok this approach? or we should include LVS/CDL prefix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-) Actual LVS implementation did not work with the current implementation of (2+1)-terminal resistors (added sub! terminal). I did not fix the LVS script (to handle the sub! parameter) because this could be more complicated, but I updated the symbols with a proper LVS_format for extraction with 2-terminal devices to work with the actual implementation of the LVS as it does before!
-) In addition, added LVS_format for spice extraction without spiceprefix (as done in nmos, pmos, etc... ) so that LVS recognizes hbt and cap_cmim devices