-
Notifications
You must be signed in to change notification settings - Fork 28
add constraints for ForeachOp arg #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: maintenance/mps20232
Are you sure you want to change the base?
Conversation
alexanderpann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works but in the constraints not only short lambda expressions should be allowed but also lambda expressions.
|
Thanks for the review. The structure only allows |
|
Right, but then the intention |
b13eadf to
451a7d1
Compare
|
I didn't like that Removing the arg specialization does not break models but it will break usages of the link, however this is probably fine because the name is the same so a refresh will re-resolve usages. |
451a7d1 to
2053cd1
Compare
2053cd1 to
d615ade
Compare
alexanderpann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess the breaking of the link can't be avoided.
fixes #1518