This repository was archived by the owner on Mar 14, 2023. It is now read-only.
Open
Conversation
niranjansy
suggested changes
May 14, 2020
niranjansy
left a comment
niranjansy
left a comment
There was a problem hiding this comment.
In your code to find minimum and maximum, the GPU code is working correctly, but the CPU code is wrong. So try to correct that.
| } | ||
| return naive_max; | ||
| } | ||
|
|
There was a problem hiding this comment.
There is a mistake in your serial code to find the maximum and minimum.
Consider the array {4, 8, 6}. Then your Find_min_CPU algorithm returns 6 as the minimum, and not 4.
Author
There was a problem hiding this comment.
Thanks ,I will do the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.