Revert "Added the ability to highlight multiple stores and remove said stores. (Redoing the PR after revert)" #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few remaining issues:
The new store types are unselectable.
The popups still display the "Remove Store" button so when a store is selected, there are two remove store buttons that do the same thing (on the sidebar and on the popup). Since we have the sidebar button, we don't need the popup button.
After clicking cancel on the confirm dialog, the previous select by list dialog is displayed. This is undesirable since the user has just cancelled and there's not a reason why they would want to add a store using the selection list.
The confirm dialog that comes up is a browser alert dialog rather than an application dialog, which works but is not ideal. It's inconsistent with the aesthetics of the other dialogs.
Stores don't deselect when clicking on the map. The individual toggling of store icons works to deselect each store one by one, but most users will expect the stores to all be deselected when clicking on the map. The usual / standard selection behavior is as follows:
a) when a new item is selected, any previously selected items are deselected.
b) to select multiple items, usually a shift or control key is held down while clicking to select.
c) when the background element is selected, all currently selected items are deselected.
The color red is usually used as a warning / error color. We might try another color (yellow, blue etc.) as a selection color. Possibly use the signature / brand color, which is used for the buttons etc. Another option is to display a square outline around the marker to make it easier to see (using the css "outline" property).