Conversation
httpretty is not maintained and no wheel is available requiring it be built, replace it with responses. Remove httpretty and mock. Use HTTPStatus.value. Replace remove_None_fields_from_dict, was leaving empty lists and dicts, with remove_empty_fields_from_dict Remove days option from csr, this option is invalid and not included in the csr. Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com>
blearandy
reviewed
Aug 13, 2025
Collaborator
There was a problem hiding this comment.
Interesting. But guess it's probably better to use https on these anyway
blearandy
approved these changes
Aug 13, 2025
Collaborator
blearandy
left a comment
blearandy
left a comment
There was a problem hiding this comment.
Man. You've been busy. Really appreciate looking at all this and updating it!
Get the local timezone where test is running. Add tzdata for Windows. Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com>
blearandy
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpretty is not maintained and no wheel is available requiring it be built, replace it with responses. Remove httpretty and mock.
Use HTTPStatus.value.
Replace remove_None_fields_from_dict, was leaving empty lists and dicts, with remove_empty_fields_from_dict.
Remove days option from csr, this option is invalid and not included in the csr.