Skip to content

add crossplane removal mode#85

Open
piotr-kotara-ibm wants to merge 2 commits intomasterfrom
add-crossplane-removal-mode
Open

add crossplane removal mode#85
piotr-kotara-ibm wants to merge 2 commits intomasterfrom
add-crossplane-removal-mode

Conversation

@piotr-kotara-ibm
Copy link
Copy Markdown
Contributor

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

if the new changes require, also:

  • Extended the tests in BedrockShim repo or created an issue for it.
    These tests should cover for example checking new expected resources or their content.

How has this code been tested

@ibm-ci-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: piotr-kotara-ibm
To complete the pull request process, please assign pgodowski
You can assign the PR to them by writing /assign @pgodowski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


data := cm.Object["data"].(map[string]interface{})

flag := data["gracfullyDelete"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • typo in the name
  • gracfullyDelete implies we will delate all crossplane, while this flag only removed finalizers. Perhaps the name shall be a bit more specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants