Skip to content

add FromEnvVar support for providers#65

Open
ppyt-pl wants to merge 4 commits intomasterfrom
fromenvvar
Open

add FromEnvVar support for providers#65
ppyt-pl wants to merge 4 commits intomasterfrom
fromenvvar

Conversation

@ppyt-pl
Copy link
Copy Markdown
Member

@ppyt-pl ppyt-pl commented Dec 23, 2021

Description of your changes

Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/50545

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

if the new changes require, also:

  • Extended the tests in BedrockShim repo or created an issue for it.
    These tests should cover for example checking new expected resources or their content.

How has this code been tested

@ibm-ci-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ppyt-pl
To complete the pull request process, please assign pgodowski
You can assign the PR to them by writing /assign @pgodowski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2021

Codecov Report

Base: 67.09% // Head: 67.15% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (32473cf) compared to base (d6f0124).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   67.09%   67.15%   +0.05%     
==========================================
  Files          67       67              
  Lines        4382     4390       +8     
==========================================
+ Hits         2940     2948       +8     
  Misses       1304     1304              
  Partials      138      138              
Flag Coverage Δ
unittests 67.15% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/controller/pkg/manager/reconciler.go 55.81% <100.00%> (+2.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ppyt-pl added a commit that referenced this pull request Dec 23, 2021
* fix resources in clusterrole

* fix clusterrole and update bundle CSV

* add CRs

* add lock to examples

* extend examples length to 2

* add labels to lock

* fix lock sample

* update bundle

* remove lock

* delete lock

* change backto one operand

* add compositeresourcedefinition sample

* fix alm-examples length

* Add labels to xrd

* make bundle update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants