Merged
Conversation
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Contributor
Author
|
test steps:
|
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Contributor
Author
|
I was wondering if we need an extra field |
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Daniel-Fan
requested changes
Mar 20, 2026
Contributor
Daniel-Fan
left a comment
Daniel-Fan
left a comment
There was a problem hiding this comment.
@qpdpQ
Can you please review the comments?
Also please update the CRD in helm chart to include the latest field changes.
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Contributor
|
Thank you for the update @qpdpQ This PR is getting flagged by the Detect Secrets check in SPS. Could you please follow the instructions to update the baseline file if this is a false positive: https://github.com/IBM/detect-secrets/tree/master |
qpdpQ
force-pushed
the
custom-entitlement
branch
from
7770622 to
0552cb9
Compare
Signed-off-by: Allen Li <liyuchen223@gmail.com>
Daniel-Fan
approved these changes
Mar 23, 2026
Contributor
Daniel-Fan
left a comment
Daniel-Fan
left a comment
There was a problem hiding this comment.
Thank you @qpdpQ
The change looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding support for customer provided entitlement key
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/68865