Skip to content

Update setup_singleton.sh to support F5 Cert Manager #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronmcohen wants to merge 1 commit into
base: scripts-dev
Choose a base branch
from
Open

Update setup_singleton.sh to support F5 Cert Manager #2626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cp3pt0-deployment/setup_singleton.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,10 +637,11 @@ function verify_cert_manager(){
info "Checking cert manager readiness."
#check webhook pod runnning
local name="cert-manager-webhook"
local f5_exclude_name="f5-cert-manager-webhook"
Copy link
Copy Markdown
Contributor

@pgodowski pgodowski Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a confirmed name, could it be customized at F5 cert manager install time?

Copy link
Copy Markdown
Member Author

@aaronmcohen aaronmcohen Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgodowski This is based on F5's documentation https://clouddocs.f5.com/service-proxy/latest/spk-cert-manager.html. I don't see any option to customize it. That being said somewhere in the universe will be a admin who chooses to edit the contents of F5's helm chart. Based on that concern... Should name and f5_exclude_name pull from an environment variable?

local retries=20
local sleep_time=15
local total_time_mins=$(( sleep_time * retries / 60))
local condition="${OC} get pod -A --no-headers --ignore-not-found | egrep '1/1' | grep ${name} || true"
local condition="${OC} get pod -A --no-headers --ignore-not-found | egrep '1/1' | grep -v ${f5_exclude_name} | grep ${name} || true"
local wait_message="Waiting for pod ${name} to be running ..."
local success_message="Pod ${name} is running."
local error_message="Timeout after ${total_time_mins} minutes waiting for pod ${name} to be running."
Expand All @@ -651,7 +652,7 @@ function verify_cert_manager(){
if [[ $webhook_deployments != "1" ]]; then
error "More than one cert-manager-webhook deployment exists on the cluster."
fi
local webhook_ns=$("$OC" get deployments -A | grep cert-manager-webhook | cut -d ' ' -f1)
local webhook_ns=$("$OC" get deployments -A | grep -v ${f5_exclude_name} | grep ${name} | cut -d ' ' -f1)

cm_smoke_test "test-issuer" "test-certificate" "test-certificate-secret" $webhook_ns
success "Cert manager is ready."
Expand Down