ILS-247 adjust to envsubst usage#2312
ILS-247 adjust to envsubst usage#2312karol-wozniak-ibm wants to merge 2 commits intoIBM:scripts-devfrom
Conversation
|
Hi @karol-wozniak-ibm. Thanks for your PR. I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...olicy/egress/license-service-reporter-manually/ibm-license-service-reporter-oidc-egress.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Godowski <piotr.godowski@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karol-wozniak-ibm, pgodowski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bitscuit Can u pls review/merge? |
| - ports: | ||
| - protocol: TCP | ||
| port: <$TargetPort> # TargetPort from the DEFAULT KUBERNETES SERVICE | ||
| - ports:S |
There was a problem hiding this comment.
Hi,
May I ask that do we expect this S in line 16?
What this PR does / why we need it:
to solve https://jsw.ibm.com/browse/ILS-166
Which issue(s) this PR fixes:
Fixes # https://jsw.ibm.com/browse/ILS-247
Special notes for your reviewer:
ILS-247-Tests.pdf