Resolve utcfromtimestamp depreciation warning #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
mynhardtburger
force-pushed
the
Resolve-.utcfromtimestamp-DepreciationWarning
branch
from
33e0112 to
03e2249
Compare
gabe-l-hart
approved these changes
Dec 18, 2025
Collaborator
gabe-l-hart
left a comment
gabe-l-hart
left a comment
There was a problem hiding this comment.
Thank you! This is a nice improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the use of the depreciated
datetime.utcfromtimestamp(timestamp)withdatetime.fromtimestamp(timestamp, tz=timezone.utc).replace(tzinfo=None). This preserves the exiting timezone naive behaviour.The approach is copied from boto/botocore#3239 and https://blog.miguelgrinberg.com/post/it-s-time-for-a-change-datetime-utcnow-is-now-deprecated
Changes
What changes are included in this PR?
Testing