Update README.md #8
Conversation
| you can log into Bluemix and the deploy your app. | ||
|
|
||
| First you should tell the `cf` command which environment you want to operate | ||
| 1. `bx login -sso -a http://api.ng.bluemix.net` (For people with @ibm.com accounts) |
There was a problem hiding this comment.
You haven't explained yet what the bx command is or how to install it. And it's only ever referenced in these 4 lines, not clear if maybe the user doesn't need to use cf if they have bx, or what. For reference, I have no idea what the bx command is myself!
There was a problem hiding this comment.
For the ibm accounts, you need to generate a token using the sso since I had trouble connecting directly to the bluemix.
| 3. Check api endpoint using `bluemix api` | ||
| 4. Push the project using `bx cf push` | ||
|
|
||
| ~~First you should tell the `cf` command which environment you want to operate |
There was a problem hiding this comment.
What's with all the double tilde's - ~~ - in these lines. The Markdown rendition just displays then as double tilde's, which is what I'd expect, but ... I don't think they're needed.
There was a problem hiding this comment.
The ~~ was for striking out the text. I thought I was making changes in my forked repo.
There was a problem hiding this comment.
No worries - you use a ~ prefix and suffix around the text you want to strike out.
Eg, to get this: "Here's some striked out text.", do this:
Here's some ~striked out~ text.
But there's no sense striking out something that you want deleted; just delete it. It'll show as deleted in the git diffs.
And yes, you are making changes in your forked repo, but I guess you created a PR in the primary repo pointing to your branch - which is the way you usually want to be doing it. Perfect!
|
Thanks for submitting the PR! I made a few basic comments, since I'm familiar with this repo, however I am no longer an IBMer, so don't have any idea if they'd accept this PR. Figured I'd add some comments anyway. Thanks again! |
2 participants
No description provided.