Added configurable timeout#6
Open
Guichaguri wants to merge 1 commit intoIAmPhoenix:masterfrom
Guichaguri:patch-1
Open
Added configurable timeout#6Guichaguri wants to merge 1 commit intoIAmPhoenix:masterfrom Guichaguri:patch-1
Guichaguri wants to merge 1 commit intoIAmPhoenix:masterfrom
Guichaguri:patch-1
Conversation
Contributor
|
Looks good |
Contributor
|
I'd like to point out i'm using this now, this is super resourceful |
Contributor
|
Does this work on Linux? I think you might have to use SO_SNDTIMEO |
Contributor
|
So actually i'm having an issue with this entirely. it has nothing to do with the platform or the option. for some reason i just can't use it.... strange. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout is very important, we can't let the user wait forever to see "server is down".
Main Reason: #5