fix: use makeAddr instead of vm.addr which creates a contract

[lirona]

this changed in foundry and made the test fail on sending to a contract that doesn't implement onERC1155Recieved

[coderabbitai]

Walkthrough

The changes update the initialization of address variables in three test contracts, switching from numeric-based address generation using vm.addr(uint) to string-based address generation using makeAddr(string). No other logic or control flow is affected in any of the tests.

Changes

Files	Change Summary
test/Hyperfund.t.sol, test/Hyperstaker.t.sol	Replaced address variable initialization from vm.addr(uint) to makeAddr(string).
test/Integration.t.sol	Updated four address variables to use makeAddr(string) instead of vm.addr(uint).

Poem

In burrows deep, with code anew,
Rabbits hop and test addresses too!
From numbers to names, a stringy delight,
Each test now shines a little more bright.
Hop, hop, hooray—our tests are clear,
With every address, the purpose is near!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

test/Hyperstaker.t.sol (1)

20-22: Descriptive Address Generation Adopted – looks good

Switching from vm.addr(uint) to makeAddr("role") produces deterministic EOAs without the side-effect of deploying contracts and makes the intent crystal-clear ("manager", "staker", …).

Optional polish for trace readability:

vm.label(manager, "manager");
vm.label(staker, "staker");
vm.label(staker2, "staker2");

Labels show up in forge test -vv logs and cost nothing at runtime.

test/Hyperfund.t.sol (1)

20-22: Cleaner address setup achieved

makeAddr("manager"), "contributor", etc. improve clarity, eliminate accidental contract creation, and keep addresses consistent across tests.

As a minor enhancement, consider adding:

vm.label(manager, "manager");
vm.label(contributor, "contributor");
vm.label(contributor2, "contributor2");

to make debug output more legible.

test/Integration.t.sol (1)

20-23: Consistent address generation – ✅

The move to makeAddr for all four actors standardises address allocation across the suite. No functional concerns spotted.

Nitpick: Labelling pays off when triaging verbose traces:

vm.label(manager, "manager");
vm.label(contributor, "contributor");
vm.label(contributor2, "contributor2");
vm.label(contributor3, "contributor3");

Purely optional, but it often saves time.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03027ac and 5247424.

📒 Files selected for processing (3)

• test/Hyperfund.t.sol (1 hunks)
• test/Hyperstaker.t.sol (1 hunks)
• test/Integration.t.sol (1 hunks)