Fw 301/execute code gen on cmake (Now working)

[Cantonplas]

Works correctly, now when you build the proyect it will create the packets and orders from your board.
You need to change the board name on the cmake tho

[jorgesg82]

Add all generated code in a .gitignore

🥰🤬

[oganigl]

For me looks good, I just looked over it.

[jdmarmen]

Great job, just one thing, as you already generate the function definitions for the callbacks in the orders I would also consider to generate the flag for each order. We always use those callbacks only to change the value of the flag, so rn the user also needs to define that flag and its also a repetitive thing, what do you think @jorgesg82 ?

[jdmarmen]

I've seen on the template ADJ that was used to test this that you asign a socket to each packet on packets.json , that's fine as we can have different datagram sockets, but, imo that should also be done with the orders, as you can send the same tcp order to different sockets. Am i missing something??

[Cantonplas]

I've seen on the template ADJ that was used to test this that you asign a socket to each packet on packets.json , that's fine as we can have different datagram sockets, but, imo that should also be done with the orders, as you can send the same tcp order to different sockets. Am i missing something??

The added selection for udp sockets is because its needed to use socket->send_packet(packet), but with the use of Orders it is not needed to specify the tcp socket its coming from. Maybe im wrong but thats why its not included or specified

😛

[oganigl]

For me it's fine, check the comment

Done