Autogenerate sockets through adj #54

Cantonplas · 2025-09-11T14:22:51Z

Now all sockets and packet period time will be described through adj, allowing the possibility of autogenerating all the code

This reverts commit 53a4131.

…al packet sending

Copilot

Pull request overview

This pull request introduces a mechanism to autogenerate socket and packet transmission configuration through the ADJ (Adjacency) system. The changes add socket definitions and packet timing information to enable code generation for network communication.

Changes:

Added new sockets.json file defining network socket configurations (ServerSocket, DatagramSocket, and Socket types) for VCU board
Enhanced packet definitions with transmission period (period, period_type) and target socket (socket) fields
Updated board configuration to reference the new sockets definition file
Extended README documentation with socket schema, field descriptions, and usage examples

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 17 comments.

File	Description
boards/VCU/sockets.json	New file defining 6 network sockets (3 TCP, 3 UDP) for control station, PCU, and HVSCU communication
boards/VCU/packets.json	Added period timing and socket routing information to 8 data packets
boards/VCU/VCU.json	Integrated sockets configuration file reference into board configuration
README.md	Added comprehensive documentation for sockets schema, updated packet schema with new fields, and added configuration rules

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T00:26:40Z

README.md


 5. **ID Uniqueness**: Board IDs must be unique across all boards. Packet IDs should be unique within their type category.

+6. **Socket Naming**: The sockets referenced inside the packet definitions must use exact names as defined in `socket.json`.


The reference should be "sockets.json" (plural) to match the actual filename, not "socket.json".

Suggested change

6. **Socket Naming**: The sockets referenced inside the packet definitions must use exact names as defined in `socket.json`.

6. **Socket Naming**: The sockets referenced inside the packet definitions must use exact names as defined in `sockets.json`.

Copilot · 2026-01-23T00:26:40Z

README.md

        "name": "Brake Telemetry",
-        "variables": ["brake_pressure", "brake_status", "brake_temperature"]
+        "variables": ["brake_pressure", "brake_status", "brake_temperature"],
+        "period_ms": 16.67,


The example uses "period_ms" as a field name, but the actual implementation uses two separate fields: "period_type" and "period". The example should be updated to match the actual schema being used throughout packets.json.

Suggested change

"period_ms": 16.67,

"period_type": "milliseconds",

"period": 16.67,

Copilot · 2026-01-23T00:26:41Z

boards/VCU/sockets.json

+    {
+        "type": "DatagramSocket",
+        "name": "hvscu_udp",
+        "remote_ip":"192.168.1.7",


Inconsistent spacing after colons in JSON. Line 46 has "remote_ip":"192.168.1.7" without a space after the colon, while other fields have spaces after colons. For consistency, consider adding a space after the colon.

Copilot · 2026-01-23T00:26:41Z

README.md

+```json
+{
+    "type": "string",
+    "name": "string",
+    "port": "number?",
+    "local_port":"number?",
+    "remote_ip": "string?",
+    "remote_port":"number?"
+
+}


The schema shows a single socket object, but the actual sockets.json file contains an array of socket objects. The schema should be wrapped in array brackets to accurately represent the structure. Change the opening brace on line 221 to an opening bracket and update line 229 accordingly.

Copilot · 2026-01-23T00:26:41Z

boards/VCU/packets.json

+        "period_type": "us",
+        "period": 16.67,


The period is set to 16.67 with period_type "us" (microseconds). This seems inconsistent with the other packets that use "ms" (milliseconds) with the same period value of 16.67. A period of 16.67 microseconds would be extremely fast (approximately 60,000 Hz). This is likely intended to be "ms" for a ~60 Hz update rate, consistent with the other packets.

Copilot · 2026-01-23T00:26:43Z

README.md

+```
+
+**Field Descriptions:**
+- `type`: Socket type string(e.g., "ServerSocket","DatagramSocket","Socket")


Missing space after colon in the field description. Should be "string (e.g.," with a space after the colon instead of "string(e.g.,".

Suggested change

- `type`: Socket type string(e.g., "ServerSocket","DatagramSocket","Socket")

- `type`: Socket type string (e.g., "ServerSocket","DatagramSocket","Socket")

Copilot · 2026-01-23T00:26:43Z

README.md

+- `period_type`: Optional string specifying the type of measurement for period, either microseconds
+or milliseconds
+- `period`: Optional number specifying the transmission period in milliseconds or microseconds for periodic packets. Can be an integer or floating-point value
+- `socket`: Optinal string that should match the name of the socket you want to transmit this packet trhough


The word "Optinal" should be spelled "Optional".

Suggested change

- `socket`: Optinal string that should match the name of the socket you want to transmit this packet trhough

- `socket`: Optional string that should match the name of the socket you want to transmit this packet trhough

Copilot · 2026-01-23T00:26:43Z

README.md

+    {
+        "type": "DatagramSocket",
+        "name": "control_station_udp",
+        "remote_ip":"192.168.0.9",


Inconsistent spacing after colons in the example JSON. Line 252 has "remote_ip":"192.168.0.9" without a space after the colon, while other fields in the example have spaces. For consistency, add a space after the colon.

Suggested change

"remote_ip":"192.168.0.9",

"remote_ip": "192.168.0.9",

Copilot · 2026-01-23T00:26:44Z

boards/VCU/sockets.json

+
+
+
+
+


Excessive blank lines at the end of the file. Lines 50-54 contain only whitespace and should be removed for cleaner formatting.

Suggested change

Copilot · 2026-01-23T00:26:44Z

boards/VCU/sockets.json

+
+

Blank lines 39-40 appear to contain only whitespace. Consider removing these extra blank lines for cleaner formatting.

JavierRibaldelRio · 2026-01-23T12:46:04Z

ADJ-Validator, now suports this PR.

Cantonplas and others added 17 commits September 10, 2025 11:45

New socket json for auto generated code (testing needed)

dc554bf

Added period and socket variables to packets.json on VCU

2385f5a

Changed period to period_ms

7698318

Testeo paquetes para la generacion de codigo automatico

3abbb54

Oops forgor to delet doble ms

9f1bb5b

More testing ongoing

a2e834d

Finished the testing

9066382

This commit will be deleted

53a4131

Revert "This commit will be deleted"

1dd8677

This reverts commit 53a4131.

Final version of new sockets json module on VCU

798c351

Mb, put vcu file outside of boards file

a61ba83

README.md updated to new auto-generated socket structure and periodic…

14fb306

…al packet sending

More README.md changes

fe0201f

Typing error in README.md sorry

2a3d0c7

chore(adj-validator): copy ADJ-Validator from test-adj

c354e43

Merge remote-tracking branch 'origin/main' into Autogenerate-Sockets

d606531

New type of variable for periodity added

df2922c

FoniksFox approved these changes Jan 22, 2026

View reviewed changes

Cantonplas requested a review from Copilot January 23, 2026 00:21

Copilot started reviewing on behalf of Cantonplas January 23, 2026 00:22 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Cantonplas and others added 2 commits January 23, 2026 01:27

Actualizar README.md

c81cb24

chore(adj-validator): copy ADJ-Validator from test-adj

76d1b30

Cantonplas requested review from jorgecanut, jorgesg82, oganigl and victor-Lopez25 January 23, 2026 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autogenerate sockets through adj #54

Autogenerate sockets through adj #54

Uh oh!

Cantonplas commented Sep 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

JavierRibaldelRio commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		5. ID Uniqueness: Board IDs must be unique across all boards. Packet IDs should be unique within their type category.

		6. Socket Naming: The sockets referenced inside the packet definitions must use exact names as defined in `socket.json`.

	"period_ms": 16.67,
	"period_type": "milliseconds",
	"period": 16.67,

	- `type`: Socket type string(e.g., "ServerSocket","DatagramSocket","Socket")
	- `type`: Socket type string (e.g., "ServerSocket","DatagramSocket","Socket")

	- `socket`: Optinal string that should match the name of the socket you want to transmit this packet trhough
	- `socket`: Optional string that should match the name of the socket you want to transmit this packet trhough

Autogenerate sockets through adj #54

Are you sure you want to change the base?

Autogenerate sockets through adj #54

Uh oh!

Conversation

Cantonplas commented Sep 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

JavierRibaldelRio commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants