Feat/sd #539
Open
Feat/sd #539
+756
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Alternate functions
…per MPU configuration
…egion outside defined ones
…symbol, to ensure initialization order doesn't matter
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…flow control just in case
jorgesg82
previously requested changes
Jan 27, 2026
Contributor
jorgesg82
left a comment
jorgesg82
left a comment
There was a problem hiding this comment.
Is there a reason to having that hal_gpio_interface.h file? It seems to be an attempt to create a mock to the GPIO module, but I don't get why it is here. If you are not using it and it is only a remaining of some merge, please delete it for this PR
FoniksFox
dismissed
jorgesg82’s stale review
It was a remaining of a merge, now deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Sd module using the new compile-infrastructure. Full documentation in the wiki.
It is a ST-LIB_LOW module even though it directly uses the HAL because it isn't actually a direct abstraction over a peripheral, but an implementation on top of it (the SDMMC peripheral is quite agnostic about what you do with it). Also, it would be great to implement an SDMMC module in HALAL, and refactor the Sd module to use that at some point in the future.
The module only allows for IDMA double-buffering mode, since it is the only mode we have a need for.