Conversation
There was a problem hiding this comment.
PR Summary:
• Removes duplicate error handling code in AnyNetAdapter::LoadData method
• Eliminates redundant if-block that checked ret != InferenceWrapper::WrapperOk
• Preserves the necessary error checking logic that follows
• Clean refactoring with no functional changes
Review Summary:
This PR correctly identifies and removes duplicate error handling code without introducing any issues. The duplicate block was immediately followed by identical error checking logic, making the removal safe and beneficial for code maintainability. No critical issues found.
Follow-up suggestions:
@devloai scan for similar duplicate code patterns across the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found these codes is duplicate as below:

So, I delete these code.