Conversation
There was a problem hiding this comment.
PR Summary:
This PR updates the MNN version requirement in the README documentation from "1.4.0 or higher" to "2.x or higher". MNN is a critical dependency as one of InspireFace's primary inference backends for face recognition operations.
Review Summary:
Reviewed the version requirement change and identified a potential compatibility issue. Based on research of the official MNN repository releases, the current MNN release series is 3.x (with 3.2.x being the latest), and the "2.x or higher" specification may exclude valid 3.x versions that users might want to use. The knowledge base emphasizes API compatibility validation as a critical review focus.
Follow-up suggestions:
README.md
Outdated
| - CMake (version 3.20 or higher) | ||
| - NDK (version 16 or higher, only required for Android) [**Optional**] | ||
| - MNN (version 1.4.0 or higher) | ||
| - MNN (version 2.x or higher) |
There was a problem hiding this comment.
The version requirement "2.x or higher" appears inconsistent with actual MNN releases. Based on the official MNN repository, the current release series is 3.x (latest: 3.2.x), and there's no evidence of a 2.9.6 version existing in the release history.
The change suggests updating from 1.4.0+ to 2.x+, but this creates a gap where valid 3.x versions would not be covered by this requirement.
Consider either:
"MNN (version 3.x or higher)"if targeting the current release series"MNN (version 2.0 or higher)"if you specifically need features from 2.x+ that aren't in 1.x
Please verify which MNN versions are actually supported and tested with InspireFace.
actions
Quick Fix: Apply a small focused fix for this specific issue (takes < 1min).
Feedback: Rate this comment to help me improve future code reviews:
- 👍 Good - Helpful and accurate
- 👎 Poor - Wrong, unclear, or unhelpful
- Skip if you don't have any strong opinions either way.
|
After testing, MNN 2.9.6 encountered errors in the armv7 architecture of this project and is temporarily closed |
No description provided.