Skip to content

Update MNN to 2.9.6#305

Closed
tunmx wants to merge 2 commits intomasterfrom
develop
Closed

Update MNN to 2.9.6#305
tunmx wants to merge 2 commits intomasterfrom
develop

Conversation

@tunmx
Copy link
Member

@tunmx tunmx commented Sep 7, 2025

No description provided.

Copy link

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

This PR updates the MNN version requirement in the README documentation from "1.4.0 or higher" to "2.x or higher". MNN is a critical dependency as one of InspireFace's primary inference backends for face recognition operations.

Review Summary:

Reviewed the version requirement change and identified a potential compatibility issue. Based on research of the official MNN repository releases, the current MNN release series is 3.x (with 3.2.x being the latest), and the "2.x or higher" specification may exclude valid 3.x versions that users might want to use. The knowledge base emphasizes API compatibility validation as a critical review focus.

Follow-up suggestions:

  • @devloai verify which MNN versions are actually tested and supported with InspireFace
  • @devloai update the version requirement to properly include all supported MNN versions

README.md Outdated
- CMake (version 3.20 or higher)
- NDK (version 16 or higher, only required for Android) [**Optional**]
- MNN (version 1.4.0 or higher)
- MNN (version 2.x or higher)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version requirement "2.x or higher" appears inconsistent with actual MNN releases. Based on the official MNN repository, the current release series is 3.x (latest: 3.2.x), and there's no evidence of a 2.9.6 version existing in the release history.

The change suggests updating from 1.4.0+ to 2.x+, but this creates a gap where valid 3.x versions would not be covered by this requirement.

Consider either:

  1. "MNN (version 3.x or higher)" if targeting the current release series
  2. "MNN (version 2.0 or higher)" if you specifically need features from 2.x+ that aren't in 1.x

Please verify which MNN versions are actually supported and tested with InspireFace.

Apply quick fix

actions

Quick Fix: Apply a small focused fix for this specific issue (takes < 1min).

Feedback: Rate this comment to help me improve future code reviews:

  • 👍 Good - Helpful and accurate
  • 👎 Poor - Wrong, unclear, or unhelpful
  • Skip if you don't have any strong opinions either way.

@tunmx
Copy link
Member Author

tunmx commented Sep 8, 2025

After testing, MNN 2.9.6 encountered errors in the armv7 architecture of this project and is temporarily closed

@tunmx tunmx closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant