Conversation
Collaborator
Author
|
Ok cleaned up the code a bit so its easier to follow and bumped up the default number of threads to 30 which work better on test and the national CDA for some reason. |
|
Collaborator
Author
|
Replaced by #219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hi Guys,
Here's a first crack at adding multithreading.
Feel free to pull and make your own changes. I used a chatbot to help with a lot of it, so the code isn't very elegant but it works (although i"m sure there's improvements to be had). It seems pretty verbose for what is.
Using the local CDA, I was able to get a 6 min non-threaded call to 20 seconds. On the national instances the performance is much worse, but I think there may be some server limiting and performance issues on those.
I imaging we would want some tests for this, but I thought it would be good to get some input first.