initial concept for reimplementing av_location_level and av_virtual_location_level#99
Draft
adamkorynta wants to merge 1 commit intomainfrom
Draft
initial concept for reimplementing av_location_level and av_virtual_location_level#99adamkorynta wants to merge 1 commit intomainfrom
adamkorynta wants to merge 1 commit intomainfrom
Conversation
…ocation_level -splitting av_location_level_ref and av_location_level_values where av_location_level_ref is designed for pagination via CDA and av_location_level_values are decorated by the paginged location_level_codes in the initially filtered av_location_level_ref - units are handled via _EN and _SI columns instead of having additional rows. This matches av_virtual_location_level, but not av_location_level - sorting is not based on fully concatenated location_level_id, but instead of the constituent parts so that full table scan isn't needed prior to sort. no sorting done within the views
MikeNeilson
reviewed
Jan 30, 2026
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Quite the improvement.
| create or replace public synonym cwms_v_location_level_values for av_location_level_values; | ||
| SELECT * | ||
| FROM av_location_level_values | ||
| WHERE ROWNUM <= 10; No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
leftover spot check, should have been in the scratch_file.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial performance improvement seen to drop from 90+ seconds for 1000 row retrieval to ~2 seconds for 1000 location level id retrieval (there are actually more than 1000 rows returned because seasonal values are normalized)