Update for latest cwms-data-api-client and OpenID Connect changes.#39
Merged
MikeNeilson merged 3 commits intomainfrom Nov 10, 2025
Merged
Conversation
oskarhurst
reviewed
Nov 10, 2025
| ApiConnectionInfo buildAuthInfo() { | ||
| String baseUrl = String.format("http://localhost:%s", mockAuthServer.getPort()); | ||
| return new ApiConnectionInfoBuilder(baseUrl).build(); | ||
| } |
There was a problem hiding this comment.
If there is an error in the BeforeAll section to my understanding the AfterAll would never get run so the tearDown might never get called.
Collaborator
Author
There was a problem hiding this comment.
I'll go check the manual to verify. That basically means a test would never clean up, at least until all tests are done. This is using random ports so that's not really a huge deal here though I think.
Collaborator
Author
There was a problem hiding this comment.
confirmed it's always called, not that we could do much anyways.
oskarhurst
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, update jacoco version for newer JDKs