refactor(java): add java catalog cache and reorganize providers#86
Open
BegoniaHe wants to merge 3 commits intoHydroRoll-Team:refactor/migrate-to-reactfrom
Open
refactor(java): add java catalog cache and reorganize providers#86BegoniaHe wants to merge 3 commits intoHydroRoll-Team:refactor/migrate-to-reactfrom
BegoniaHe wants to merge 3 commits intoHydroRoll-Team:refactor/migrate-to-reactfrom
Conversation
add src-tauri/src/core/java/cache.rs for Java catalog caching reorganize provider interfaces and move detection/install changes update persistence, adoptium provider and validation Reviewed-by: Raptor mini (Preview)
|
@BegoniaHe is attempting to deploy a commit to the retrofor Team on Vercel. A member of the Team first needs to authorize it. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @BegoniaHe, your pull request is larger than the review limit of 150000 diff characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Java subsystem for the DropOut Minecraft launcher by introducing catalog caching, reorganizing provider architecture, and adding TypeScript bindings via ts-rs. Based on PR #77, it includes a new React-based UI (ui-new) alongside backend refactoring.
Changes:
- Adds Java catalog caching with 24-hour validity (cache.rs)
- Introduces provider trait pattern for extensible Java distribution support
- Splits detection logic into platform-specific modules
- Adds priority-based Java resolution for game launches
- Generates TypeScript bindings for all core data structures
- Introduces new React UI with Zustand state management
Reviewed changes
Copilot reviewed 101 out of 103 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src-tauri/src/core/java/cache.rs | New 24-hour catalog caching with atomic file writes |
| src-tauri/src/core/java/provider.rs | Provider trait for Java distributions |
| src-tauri/src/core/java/providers/adoptium.rs | Adoptium provider implementation with parallel fetching |
| src-tauri/src/core/java/validation.rs | Extracted validation logic with async support |
| src-tauri/src/core/java/persistence.rs | User configuration persistence |
| src-tauri/src/core/java/priority.rs | Priority-based Java resolution for launches |
| src-tauri/src/core/java/install.rs | Extracted installation logic |
| src-tauri/src/core/java/detection/* | Platform-specific detection modules |
| src-tauri/src/main.rs | Updated to use new Java resolution and provider APIs |
| src-tauri/src/core/auth.rs | Changed CLIENT_ID back to DropOut's own Azure app |
| packages/ui-new/* | Complete new React-based UI implementation |
| setNewInstanceName(""); | ||
| }; | ||
|
|
||
| const confirmEdit = async () => { |
There was a problem hiding this comment.
Unused variable confirmEdit.
- Update .github/copilot-instructions.md Reviewed-by: GitHub Copilot CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
描述
detection.rs拆分为平台子模块（detection/{linux,macos,windows,unix,common}.rs），并新增install.rs以整理安装流程。persistence.rs、providers/adoptium.rs、validation.rs以配合重构。更改类型
LLM 生成代码声明
相关 Issue
更改内容
后端 (Rust)
java::detection到平台实现，新增install.rs。persistence.rs、providers/adoptium.rs、validation.rs等，整理 provider 接口与实现。前端 (Svelte)
配置
测试
测试环境
测试结果摘要
cargo test：测试用例
测试步骤
cargo test检查清单
代码质量
测试验证
文档更新
依赖项
附加说明
维护者专用