Draft
Conversation
|
I was able to adapt glTexImage2DAsync to BlocksDS's libnds since I migrated one of my rom hack ports to BlocksDS independently a few weeks back, but I have no clue how to contribute to someone else's pull request. Essentially, BlocksDS removed a few things off the headers and made one of the used functions static. If you add those back and change some arrow operators to dot operators, it'll work again. If needed, I can fork your fork and add the changes. |
Author
|
You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glTexImage2DAsyncneeds to be adapted for BlocksDS's libnds, so I've commented it out for now, I assume you can probably pretty easily take care of it. Other than that everything seems to be good.