-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add Fetch Email-Config button to admin email channel editor #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snoller
wants to merge
9
commits into
main
Choose a base branch
from
feat_fetch_email_credentials
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e150363
feat: add Fetch Email-Config button to admin email channel editor
snoller afb6a88
fix: map upstream HybridAI errors to 502 to avoid gateway auth confusion
snoller 76474bd
fix: handle nested HybridAI error payloads and set no-store cache header
snoller 9993e82
fix: use ghost-button styling consistent with rest of channels page
snoller 80cb94b
fix: show success toast only after password secret is saved
snoller fa322a8
Merge branch 'main' into feat_fetch_email_credentials
furukama a226518
fix: gate hybridai agent email import
5a2985d
chore: format email channel editor
5dc1643
fix: use correct HybridAI mailbox credentials API
snoller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New behavior (Fetch Email-Config button + draft updates + optional runtime secret write) is introduced here, but there are existing tests for this page (console/src/routes/channels.test.tsx) and none cover this flow. Please add tests for: successful fetch populating IMAP/SMTP fields; no handles / no email_config cases; and password save path calling setRuntimeSecret.