Skip to content

feat: Add Joker Theme#98

Closed
aliasgharfathikhah wants to merge 8 commits intoHyDE-Project:masterfrom
aliasgharfathikhah:master
Closed

feat: Add Joker Theme#98
aliasgharfathikhah wants to merge 8 commits intoHyDE-Project:masterfrom
aliasgharfathikhah:master

Conversation

@aliasgharfathikhah
Copy link

Introduce a little anarchy to the theme gallery... Why so serious?

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 4, 2025

@kRHYME7 kRHYME7 marked this pull request as draft August 4, 2025 05:30
@aliasgharfathikhah
Copy link
Author

Hello,

My apologies for the previous incorrect submission. I mistakenly edited the README file directly instead of following the proper procedure.

I have now corrected the submission according to the contribution guidelines:

  1. Added the "Joker" theme entry to the hyde-themes.json file.
  2. Placed the preview image in the correct ./Joker/preview.png directory.
  3. Regenerated the README.md file using the generate_readme.py script to reflect the changes automatically.

The theme should now be correctly formatted. I would appreciate it if you could review the changes.

Thank you!

@aliasgharfathikhah aliasgharfathikhah marked this pull request as ready for review August 5, 2025 04:44
@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 5, 2025

@aliasgharfathikhah Hi! please follow the theming guide in here (this helper/guide is made by @richen604 )

https://hydeproject.pages.dev/en/theming/making-themes/

As you can see, the theme installation fails
image

@aliasgharfathikhah
Copy link
Author

Hello again,

Thank you for your patience and guidance. I apologize for the initial confusion with the repository structure.

I have now corrected the directory layout to match the contribution guidelines. All theme files are placed under the Configs/.config/hyde/themes/Joker path.

Hope everything is in order now. Ready for your review!

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 5, 2025

Can you try it with the command in the screenshot? I need some proof because I'm not on my Laptop right now.

@aliasgharfathikhah
Copy link
Author

Since it's still not working after I fixed the directory structure, could you please clarify the issue for me? I need to know if the problem is with the installation or with the theme application itself.

  1. Are you still getting the exact same [ERROR] ... Do Not Exist as before?
  2. Or, does the command run successfully now without errors, but the theme just doesn't apply visually (the colors, bar, etc. don't change)?

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 5, 2025

You added a GTK theme but you did not provide the GTK theme source.

I think you can check how the themes are structured by others.See @HyDE-Project/rice-stars and check there themes on how they do it.

image

you missed some GTK and ICON files that's why we got errors like this

image

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 5, 2025

@HyDE-Project/rice-stars anyone who can help @aliasgharfathikhah ?

@aliasgharfathikhah
Copy link
Author

I think I understand the problem now.

It seems I need to package the complete GTK theme and Icon theme as .tar.gz archives and place them in the repository root, instead of just providing the config files and loose icon folders.

No worries, I will work on fixing this now and will push an update with the correct packages soon. I'll let you know when it's ready for another test.

Thanks for your help!

@aliasgharfathikhah
Copy link
Author

After reviewing the feedback, I've decided to simplify the theme for now. I have removed the GTK and Icon theme dependencies entirely from the hypr.theme file.

This should now be treated as a "config-only" theme that styles Hyprland, Kitty, Waybar, etc., without altering the user's existing GTK and Icon themes. I am still developing the custom GTK and Icon themes and plan to release them as a complete package in a future update.

This change should resolve all current installation errors. Could you please check it one last time? Thank you for your continued help!

@aliasgharfathikhah
Copy link
Author

@kRHYME7 Is everything okay?

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 5, 2025

Nope it will fail. Gtk theme is required for theming.

Here are the avialable archive you can add.
image


Only gtk-theme is mandatory here. The reason for that is GTK is so, so, huge and being use by most linux apps.

image

@aliasgharfathikhah
Copy link
Author

Hi again,

Thank you for the detailed feedback and for your patience. I understand now that the GTK theme package is a mandatory requirement. My apologies for the oversight.

I have now corrected everything based on your last instructions:

  1. I've added the properly packaged Gtk_Joker.tar.gz to the root of the repository.
  2. The hypr.theme file has been updated to include the necessary $GTK_THEME variable.

This should resolve all installation errors. I would be very grateful if you could give it one final test when you have a moment.

Thank you again for all your help in guiding me through this!

@Maroc02
Copy link
Contributor

Maroc02 commented Aug 5, 2025

A few important points:

  1. Refer to one of the official themes’ repositories to understand the correct theme structure.
  2. All source files (GTK themes, icons, etc.) should be placed in the Source/arcs/ directory at the root of the project.
  3. GTK theme folder naming:
    When extracting a GTK theme archive, the resulting folder name MUST match the one defined in hypr.theme.
    For example:
    If hypr.theme contains $GTK_THEME = Joker, then Gtk_Joker.tar.gz should extract to a folder named Joker, NOT Gtk_Joker.
  4. Keep your fork of the gallery up to date.
    Recent changes were made to the gallery, so make sure your fork is up to date.

@aliasgharfathikhah
Copy link
Author

aliasgharfathikhah commented Aug 5, 2025

I believe I have now addressed all the structural requirements.

  • The Gtk_Joker.tar.gz archive is now located in the Source/arcs/ directory.
  • The archive correctly extracts to a top-level Joker folder.
  • I have also updated my fork of the gallery to be in sync with the latest changes from the main repository.

Everything should be in order now. I would really appreciate it if you could take another look.

Thank you for your guidance and patience through this process!

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 5, 2025

image

The ./Kvantum/ are not populated, as the naming is not correct. Though that file is not mandatory, but just letting you know.

Please rename it accordingly.

Another one is your Font. To make it work, compress it like the Gtk too.


I will still merge this one because it is still working as intended.

@aliasgharfathikhah
Copy link
Author

I have pushed the final updates. The Kvantum theme and the Font are now correctly packaged and placed in the Source/arcs/ directory, and the hypr.theme file has been updated accordingly.

Everything should now be fully compliant with all the guidelines. Thank you very much for your patience and for guiding me through this process. I would be grateful if you could merge the theme into the gallery.

Thanks again for everything!

@Maroc02
Copy link
Contributor

Maroc02 commented Aug 5, 2025

Hey, hopefully the last set of changes:

  • The extracted font folder name has to match whatever is set in hypr.theme for $FONT (the font doesn't patch, as seen in the image below). The extracted folder is currently called fonts instead of Joker.
image
  • The kvantum folder should be present inside the theme folder (as seen in the image below, using one of my themes as an example). Also, the Kvantum files should be called kvantum.theme and kvconfig.theme. Additionally, your Joker.kvconfig (correctly kvconfig.theme) is missing the following line at the top of the file:
    $HOME/.config/Kvantum/wallbash/wallbash.kvconfig
    (At least I think it's needed anyways).
image
  • You're also missing waybar.theme (it may work without it - not sure).

  • Your last commit broke the gallery previews (as shown in the image below, you have some miss-typos in the README.md).

image

@boulder-roller
Copy link

is it just me or is bro writing his responses with chatgpt

README.md Outdated
**Description:** Monochrome based theme

[![1-Bit Preview](1-Bit/screenshot.png)](https://github.com/amit-0i/1-Bit) <a href="#theme-gallery" title="Back to top"><img src="https://img.shields.io/badge/↑-Back_to_Top-FCFCFC?style=flat&labelColor=131313&color=131313" alt="Back to Top" style="vertical-align: middle;"></a>
[![1-Bit Preview](1-Bit%5Cscreenshot.png)](https://github.com/amit-0i/1-Bit) <a href="#theme-gallery" title="Back to top"><img src="https://img.shields.io/badge/↑-Back_to_Top-FCFCFC?style=flat&labelColor=131313&color=131313" alt="Back to Top" style="vertical-align: middle;"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you do this?
revert these changes

@boulder-roller
Copy link

@kRHYME7 am i allowed to NAK this?

@aliasgharfathikhah
Copy link
Author

Alright, let's try this again, shall we? 😉

I've pushed the final fixes based on all the feedback. Everything should actually be working this time.

Here's the rundown:

  • Font & Kvantum: All packaged up and structured exactly as requested. My apologies for the initial confusion on those.
  • Waybar: Renamed back to waybar.theme.

Regarding the README.md... that generate_readme.py script of yours seems to have a bit of a personality! It really doesn't seem to like Windows systems and broke all the preview links. No worries, I've gone in and manually fixed the markdown formatting myself. The gallery should look pretty again.

Thanks for all the guidance. Let me know if this masterpiece is finally ready to be merged!

@aliasgharfathikhah
Copy link
Author

It's better to be a little more polite and create a script that works everywhere.

@aliasgharfathikhah
Copy link
Author

joker.gif.mp4

@amit-0i
Copy link

amit-0i commented Aug 6, 2025

@aliasgharfathikhah fix the installation guide in your theme repo. for reference, check other theme repos

@aliasgharfathikhah
Copy link
Author

@amit-0i I fixed it.

@amit-0i
Copy link

amit-0i commented Aug 6, 2025

@aliasgharfathikhah
image
the link is incorrect. also, the theme can be added using hydectl theme import and a cli will show up.

image

@aliasgharfathikhah
Copy link
Author

@amit-0i I fixed it.

@amit-0i
Copy link

amit-0i commented Aug 6, 2025

@aliasgharfathikhah
the waybar config is all messed up, did you follow the theme making guide? the theme is all messed up.
image

@aliasgharfathikhah
Copy link
Author

@amit-0i Can you help? Let's fix the theme? My system is currently Windows. I wanted this for a gift and to add it to the gallery. And I really want it to be made. If possible, help me with the problems and fix them in my repository.

@saber-88
Copy link
Contributor

saber-88 commented Aug 6, 2025

@amit-0i Can you help? Let's fix the theme? My system is currently Windows. I wanted this for a gift and to add it to the gallery. And I really want it to be made. If possible, help me with the problems and fix them in my repository.

250806_14h23m27s_screenshot your waybar.theme file should look something like this

@boulder-roller
Copy link

how did you take the screenshots of the theme if you're on windows?

@aliasgharfathikhah
Copy link
Author

how did you take the screenshots of the theme if you're on windows?

One of my friends uses Linux, so I sent him the theme — he configured it and tested it out.

@aliasgharfathikhah
Copy link
Author

@amit-0i Can you help? Let's fix the theme? My system is currently Windows. I wanted this for a gift and to add it to the gallery. And I really want it to be made. If possible, help me with the problems and fix them in my repository.

250806_14h23m27s_screenshot your waybar.theme file should look something like this

Can you check this? : https://github.com/aliasgharfathikhah/hyde-joker-theme

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 6, 2025

Looks like you should discuss this in the theme repo.

@saber-88
Copy link
Contributor

saber-88 commented Aug 6, 2025

refer to one of already existing theme repos which are in hyde-gallery and see the diffs in your configs.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 7, 2025

Hello @aliasgharfathikhah As a maintainer for this gallery I would like to assess if you are capable or there is/will be someone to help you maintain this theme.

I am not talking about any aesthetic standards here. We don't have any standards, as long as it will install, not broken and looks good for you then please add it in the gallery.

However,you should know that other people will use this. If they have problems like missing gtk stuff etc, we need someone to at least fix issues for the theme.

Let me know if you will continue to maintain this theme or you will have a co maintainer. That assures that this theme will not be abandoned.

Thank you!

@aliasgharfathikhah
Copy link
Author

Hi @kRHYME7 , yes, my friends and I will develop it and improve it and implement the necessary standards for proper implementation and we will not give up until it works properly. And after that, we will maintain it. Thanks for the information.

@boulder-roller
Copy link

boulder-roller commented Aug 8, 2025 via email

@Maroc02
Copy link
Contributor

Maroc02 commented Aug 14, 2025

i dont buy it

On Fri, 8 Aug 2025, 18:55 علی اصغر فتحی خواه, @.> wrote: aliasgharfathikhah left a comment (HyDE-Project/hyde-gallery#98) <#98 (comment)> Hi @kRHYME7 https://github.com/kRHYME7 , yes, my friends and I will develop it and improve it and implement the necessary standards for proper implementation and we will not give up until it works properly. And after that, we will maintain it. Thanks for the information. — Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BMQRDEAN676YT4MPKECTE5D3MRQWLAVCNFSM6AAAAACCWVASS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRXGA3TONZSHA . You are receiving this because you commented.Message ID: @.>

image

@its-19818942118
Copy link

Hi @kRHYME7 , yes, my friends and I will develop it and improve it and implement the necessary standards for proper implementation and we will not give up until it works properly. And after that, we will maintain it. Thanks for the information.

you know it really cannot be merged? since its not a proper theme yet. a config only theme can be literally any them at all. with just base catppuccin mocha and what not? +- borders blur and things like that. in my eyes this doesn't count as a theme. but rather a configuration style. It is possible to merge it incase of proper themeing and compliance with the style guide.

@Prof-Shiba
Copy link
Member

definitely the most interesting pr here so far

@aliasgharfathikhah
Copy link
Author

its

Yes
Just to confirm: I’d like to use the base of this project (https://github.com/HyDE-Project/hyde-gallery/tree/master#bad-blood) for my own work—sounds great! If there’s anything I need to keep in mind (like attribution or licensing), please let me know.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 17, 2025

Just add GPL3 as the license and it should be fine. Goodluck!

@kRHYME7 kRHYME7 marked this pull request as draft August 19, 2025 13:51
@boulder-roller
Copy link

@kRHYME7 @Maroc02 i submitted a pr to bro's repo to add the license if it doesn't get merged then ig there's not going to be a joker theme :joker2:

@aliasgharfathikhah
Copy link
Author

@kRHYME7 @Maroc02 i submitted a pr to bro's repo to add the license if it doesn't get merged then ig there's not going to be a joker theme :joker2:

Merged

@its-19818942118
Copy link

👍🏻 great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants