Skip to content

feat(Joker)#102

Merged
kRHYME7 merged 3 commits intoHyDE-Project:masterfrom
saber-88:master
Oct 3, 2025
Merged

feat(Joker)#102
kRHYME7 merged 3 commits intoHyDE-Project:masterfrom
saber-88:master

Conversation

@saber-88
Copy link
Contributor

@saber-88 saber-88 commented Sep 20, 2025

Joker theme for hyde

@saber-88 saber-88 requested review from Maroc02 and kRHYME7 September 20, 2025 10:36
@boulder-roller
Copy link

that's not how that works :joker2:

@boulder-roller
Copy link

why is the pr comment a markdown file that's part of the pr and not just in the source repo?
there's no license in the theme repo.
did you even use the script to make these changes?

@boulder-roller
Copy link

why so serious

@saber-88
Copy link
Contributor Author

why is the pr comment a markdown file that's part of the pr and not just in the source repo? there's no license in the theme repo. did you even use the script to make these changes?

what license ?

@saber-88
Copy link
Contributor Author

@boulder-roller can you please review again i have made few changes

@boulder-roller
Copy link

did you use the script to make the changes?

@saber-88
Copy link
Contributor Author

saber-88 commented Oct 1, 2025

did you use the script to make the changes?

which script ? generate_readme.py ? yes i used it . if you are talking about any other script then i didn't

@boulder-roller
Copy link

lgtm :joker2:
@Maroc02 thoughts lmao

Copy link
Contributor

@Maroc02 Maroc02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks correct:

  • The links are valid.
  • The theme installs properly (see the screenshot below).
  • README.md is correctly generated.
image

Minor Note:

I’m getting gradient errors on Hyprdots, which do NOT seem to occur on HyDE (as confirmed by Shabba).

Otherwise, the theme works as expected.

image

Copy link
Collaborator

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so serious?

@kRHYME7 kRHYME7 merged commit c5f5bca into HyDE-Project:master Oct 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants