Merged
Conversation
Port the rich-note demo to ReactLynx. Uses <text> inline context with nested <view> for chips/code spans and vertical-align for baseline alignment (Lynx has no CSS inline layout). Known issue: layoutInlineItems can overflow maxWidth at certain widths when chips fill a line tightly. Tracked upstream at chenglou/pretext#88.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<text>inline context with nested<view>for chips and code spans, withverticalAlignfor baseline alignment (Lynx has no CSS inline layout)<view>elements require explicitwidthsince they don't auto-size in Lynx's inline formatting contextKnown Issue
layoutInlineItemscan overflowmaxWidthby ~4px at certain widths when chips fill a line tightly. Tracked in #3.Test plan
pnpm buildpasses inexamples/basic