-
Notifications
You must be signed in to change notification settings - Fork 0
Create arm subsystem #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gcschmit
wants to merge
3
commits into
main
Choose a base branch
from
armSubsysten-Kush
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package frc.robot.subsystems.arm; | ||
|
|
||
| import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
| import frc.robot.subsystems.arm.ArmIO.ArmIOInputs; | ||
|
|
||
| public class Arm extends SubsystemBase { | ||
| private ArmIO io; | ||
|
|
||
| private final ArmIOInputs inputs = new ArmIOInputs(); | ||
|
|
||
| public Arm(ArmIO io) { | ||
| this.io = io; | ||
| } | ||
|
|
||
| @Override | ||
| public void periodic() { | ||
| io.updateInputs(inputs); | ||
| } | ||
|
|
||
| public void goToAngle(double angleDeg) { | ||
| io.setAngle(angleDeg); | ||
| } | ||
|
|
||
| public double getAngle() { | ||
| return inputs.positionDeg; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package frc.robot.subsystems.arm; | ||
|
|
||
| import edu.wpi.first.wpilibj.xrp.XRPServo; | ||
|
|
||
| public interface ArmIO { | ||
|
|
||
| public static class ArmIOInputs { | ||
|
|
||
| public double positionDeg = 0.0; | ||
|
|
||
| } | ||
|
|
||
| public default void updateInputs(ArmIOInputs inputs){} | ||
|
|
||
| public default void setAngle(double angleDeg){} | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package frc.robot.subsystems.arm; | ||
|
|
||
| import edu.wpi.first.wpilibj.xrp.XRPServo; | ||
|
|
||
| public class ArmIOXRP implements ArmIO{ | ||
|
|
||
| private final XRPServo armMotor = new XRPServo(4); | ||
|
|
||
| @Override | ||
| public void updateInputs(ArmIOInputs inputs) { | ||
| inputs.positionDeg = armMotor.getAngle(); | ||
| } | ||
|
|
||
| @Override | ||
| public void setAngle(double angleDeg) { | ||
| armMotor.setAngle(angleDeg); | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IO classes define an inner class for its IO inputs (e.g., ArmIOInputs). This class has properties for each value that is retrieved from the device. In this case, probably only the position (e.g, positionDeg).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IO classes also have an updateInputs method to update the specified inputs object.