Skip to content

[ISSUE-750] feat(en-us): add player gear status strings #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haato3o merged 1 commit into from
Jan 5, 2026
Merged

[ISSUE-750] feat(en-us): add player gear status strings #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions localization/en-us.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4390,6 +4390,18 @@
<Setting Id="DAMAGE_METER_SHOULD_SHOW_DAMAGE"
String="Show total damage"
Description="If enabled, HunterPie will display each player's total damage." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_STATUS"
String="Show player status"
Description="If enabled, HunterPie will display each player's status." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_AFFINITY"
String="Show player affinity"
Description="If enabled, HunterPie will display each player's current affinity." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_RAW_DAMAGE"
String="Show player true raw damage"
Description="If enabled, HunterPie will display each player's current true raw damage." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_ELEMENTAL_DAMAGE"
String="Show player elemental damage"
Comment on lines +4394 to +4403
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The String attributes for these new settings include "player" in the text (e.g., "Show player status", "Show player affinity"), which is inconsistent with the existing similar settings in this section. For example, line 4388 uses "Show DPS" and line 4391 uses "Show total damage" without the word "player". Consider removing "player" from these String values to maintain consistency: "Show status", "Show affinity", "Show true raw damage", and "Show elemental damage".

Suggested change
String="Show player status"
Description="If enabled, HunterPie will display each player's status." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_AFFINITY"
String="Show player affinity"
Description="If enabled, HunterPie will display each player's current affinity." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_RAW_DAMAGE"
String="Show player true raw damage"
Description="If enabled, HunterPie will display each player's current true raw damage." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_ELEMENTAL_DAMAGE"
String="Show player elemental damage"
String="Show status"
Description="If enabled, HunterPie will display each player's status." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_AFFINITY"
String="Show affinity"
Description="If enabled, HunterPie will display each player's current affinity." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_RAW_DAMAGE"
String="Show true raw damage"
Description="If enabled, HunterPie will display each player's current true raw damage." />
<Setting Id="DAMAGE_METER_SHOULD_SHOW_ELEMENTAL_DAMAGE"
String="Show elemental damage"

Copilot uses AI. Check for mistakes.
Description="If enabled, HunterPie will display each player's current elemental damage." />
<Setting Id="DAMAGE_METER_ENABLE_SLIDING_WINDOW"
String="Enable moving average DPS plotting"
Description="If enabled, HunterPie will plot your average DPS for the last X seconds, at X second intervals (can be customized via Plot sampling rate setting)." />
Expand Down Expand Up @@ -4529,6 +4541,8 @@
String="ACCOUNT" />
<Group Id="CONFIGURATION_GROUP_FLAGS"
String="FEATURE FLAGS" />
<Group Id="CONFIGURATION_GROUP_GEAR_STATUS"
String="GEAR STATUS" />
</ConfigurationGroups>
<Home>
<GameStatus Id="NOT_FOUND"
Expand Down