fix: UTC-568: VideoTag playback speed attributes validation#759
Open
fix: UTC-568: VideoTag playback speed attributes validation#759
Conversation
This was referenced Feb 12, 2026
Contributor
Author
|
/git merge |
hakan458
reviewed
Feb 17, 2026
| """ """ | ||
| return examples.get("Video") | ||
|
|
||
| def _parse_speed_attr(self, attr_name: str) -> Optional[float]: |
Contributor
There was a problem hiding this comment.
maybe should have a generic function in LabelInterface that gets any attribute as the raw string. Then in validate_config for this class you can cast it to float
hakan458
approved these changes
Feb 17, 2026
Contributor
hakan458
left a comment
hakan458
left a comment
There was a problem hiding this comment.
Left suggestion but looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.