fix: OBB corner detection in convert_yolo_obb_to_annotation#682
Open
arda92a wants to merge 1 commit intoHumanSignal:masterfrom
Open
fix: OBB corner detection in convert_yolo_obb_to_annotation#682arda92a wants to merge 1 commit intoHumanSignal:masterfrom
arda92a wants to merge 1 commit intoHumanSignal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OBB Corner Detection in
convert_yolo_obb_to_annotationProblem
The previous implementation calculated the top-left corner of oriented bounding boxes (OBBs) using geometric transformations from the center point. This approach could produce incorrect corner positions, especially for rotated boxes, as it relied on assumptions about coordinate ordering that may not hold for all YOLO OBB outputs.
Solution
This PR refactors the corner detection logic to explicitly identify the actual top-left corner from the provided coordinates:
Changes