Skip to content

Use nodeId for visitNodes. #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliceofhartley wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −5
Open

Use nodeId for visitNodes. #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31e7049
Use nodeId for visitNodes.
aliceofhartley Feb 16, 2026
f7ae96d
Fix missing line.
aliceofhartley Feb 16, 2026
0d349fa
Fix incorrect line.
aliceofhartley Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/modules/utils/getDeclarationWithContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export function getDeclarationWithContext(originNode, excludeOriginNode = false)
const stack = [originNode]; // The working stack for nodes to be reviewed
/** @type {ASTNode[]} */
const collected = []; // These will be our context
/** @type {Set<ASTNode>} */
/** @type {Set<number>} */
const visitedNodes = new Set(); // Track visited nodes to prevent infinite loops
/** @type {number[][]} */
const collectedRanges = []; // Prevent collecting overlapping nodes
Expand All @@ -149,7 +149,7 @@ export function getDeclarationWithContext(originNode, excludeOriginNode = false)
*/
function addToStack(node) {
if (!node ||
visitedNodes.has(node) ||
visitedNodes.has(node.nodeId) ||
stack.includes(node) ||
SKIP_TRAVERSAL_TYPES.includes(node.type)) {
return;
Expand All @@ -164,8 +164,8 @@ export function getDeclarationWithContext(originNode, excludeOriginNode = false)
if (!cached) {
while (stack.length) {
const node = stack.shift();
if (visitedNodes.has(node)) continue;
visitedNodes.add(node);
if (visitedNodes.has(node.nodeId)) continue;
visitedNodes.add(node.nodeId);
// Do not collect any context if one of the relevant nodes is marked to be replaced or deleted
if (node.isMarked || doesDescendantMatchCondition(node, n => n.isMarked)) {
collected.length = 0;
Expand Down Expand Up @@ -223,7 +223,7 @@ export function getDeclarationWithContext(originNode, excludeOriginNode = false)

for (let i = 0; i < targetNodes.length; i++) {
const targetNode = targetNodes[i];
if (!visitedNodes.has(targetNode)) stack.push(targetNode);
if (!visitedNodes.has(targetNode.nodeId)) stack.push(targetNode);
// noinspection JSUnresolvedVariable
if (targetNode === targetNode.scope.block) {
// Collect out-of-scope variables used inside the scope
Expand Down