Fix proxy resolution, escodegen crash, and cache collision bugs#152
Open
erikbilyk wants to merge 6 commits intoHumanSecurity:mainfrom
Open
Fix proxy resolution, escodegen crash, and cache collision bugs#152erikbilyk wants to merge 6 commits intoHumanSecurity:mainfrom
erikbilyk wants to merge 6 commits intoHumanSecurity:mainfrom
Conversation
…nt cross-scope collisions
…replacement nodes
|
Just fyi your PR fails 4 tests in the test suite. Also if you're doing work with large javascript files, you might be interested in my forks of restringer, flast, and obfuscation-detector. If you look through the branches I have a set of performance and memory optimizations. I have PRs open for most of them, so hopefully they'll be merged at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several bugs encountered when deobfuscating large real-world scripts:
value: nullproperty to Null case in createNewNode, and added recursive validation of replacement node treesnew Function("return this")()can be parsedTest plan