Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm reports vuln with js-yaml 4.1.0.
Bumped version to 4.1.1.
npm log
❯ npm install
added 95 packages, and audited 96 packages in 857ms
24 packages are looking for funding
run
npm fundfor details1 moderate severity vulnerability
To address all issues, run:
npm audit fix
Run
npm auditfor details.❯ npm audit fix
changed 1 package, and audited 96 packages in 540ms
24 packages are looking for funding
run
npm fundfor detailsfound 0 vulnerabilities
❯ npm run test
▶ Arborist tests
✔ Verify node replacement works as expected (7.456105ms)
✔ Verify the root node replacement works as expected (0.595748ms)
✔ Verify only the root node is replaced (0.540034ms)
✔ Verify node deletion works as expected (1.733128ms)
✔ Verify the correct node is targeted for deletion (1.089865ms)
✔ Verify a valid script can be used to initialize an arborist instance (0.671668ms)
✔ Verify a valid AST array can be used to initialize an arborist instance (0.434421ms)
✔ Verify invalid changes are not applied (0.921538ms)
✔ Verify comments aren't duplicated when replacing the root node (1.070429ms)
﹣ FIX: Verify comments are kept when replacing a node (0.247082ms) # SKIP
✔ Arborist tests (15.826751ms)
▶ Arborist edge case tests
✔ Preserves comments when replacing a non-root node (0.910159ms)
✔ Deleting the only element in an array leaves parent valid (0.519814ms)
✔ Multiple changes in a single pass (replace and delete siblings) (1.115268ms)
✔ Deeply nested node replacement (1.752005ms)
✔ Multiple comments on a node being deleted (2.054137ms)
✔ Marking the same node for deletion and replacement only applies one change (0.653089ms)
✔ AST is still valid and mutable after applyChanges (0.696875ms)
✔ Arborist edge case tests (8.173991ms)
▶ Functionality tests
✔ Verify the code breakdown generates the expected nodes by checking the properties of the generated ASTNodes (9.491835ms)
✔ Verify the expected functions and classes can be imported (0.608029ms)
✔ Verify the code breakdown generates the expected nodes by checking the number of nodes for each expected type (2.067652ms)
✔ Verify the AST can be parsed and regenerated into the same code (2.597174ms)
✔ Verify generateFlatAST's detailed option works as expected (3.374872ms)
✔ Verify a script is parsed in "sloppy mode" if strict mode is restricting parsing (1.497487ms)
✔ Verify a script is only parsed in its selected sourceType (0.704435ms)
✔ Verify generateFlatAST doesn't throw an exception for invalid code (0.661144ms)
✔ Functionality tests (22.76712ms)
▶ Parsing tests
✔ Verify the function-expression-name scope is always replaced with its child scope (11.554331ms)
✔ Verify declNode references the local declaration correctly (1.393298ms)
✔ Verify a function's identifier isn't treated as a reference (0.57433ms)
✔ Verify proper handling of class properties (2.094715ms)
✔ Verify the type map is generated accurately (0.988478ms)
✔ Verify node relations are parsed correctly (1.056518ms)
✔ Verify the module scope is ignored (0.50512ms)
✔ Verify the lineage is correct (0.690636ms)
✔ Verify null childNodes are correctly parsed (0.527516ms)
✔ Verify all identifiers are referenced correctly (0.743958ms)
✔ Parsing tests (21.398251ms)
▶ Utils tests: treeModifier
✔ Verify treeModifier sets a generic function name (0.851367ms)
✔ Verify treeModifier sets the function's name properly (0.216649ms)
✔ Utils tests: treeModifier (2.964686ms)
▶ Utils tests: applyIteratively
✔ Verify applyIteratively cannot remove the root node without replacing it (7.039149ms)
✔ Verify applyIteratively catches a critical exception (1.122724ms)
✔ Verify applyIteratively works as expected (4.979594ms)
✔ Utils tests: applyIteratively (13.441365ms)
▶ Utils tests: logger
✔ Verify logger sets the log level to DEBUG properly (0.413499ms)
✔ Verify logger sets the log level to NONE properly (0.34035ms)
✔ Verify logger sets the log level to LOG properly (0.3069ms)
✔ Verify logger sets the log level to ERROR properly (0.302871ms)
✔ Verify logger sets the log function properly (0.436473ms)
✔ Verify logger throws an error when setting an unknown log level (0.442244ms)
✔ Utils tests: logger (2.768148ms)
ℹ tests 46
ℹ suites 7
ℹ pass 45
ℹ fail 0
ℹ cancelled 0
ℹ skipped 1
ℹ todo 0
ℹ duration_ms 146.422113