Skip to content

Conversation

@xgui3783
Copy link
Collaborator

@xgui3783 xgui3783 commented Oct 27, 2025

This PR adds CI/CD which:

  • builds on each push
  • publishes on pypi on tag

largely following guide from https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#workflow-definition


edit: TODO: after merge, someone with pypi publish right (me, andrew etc) will need to continue the guide, specifically registering trusted publishing at https://pypi.org/manage/account/publishing/

@xgui3783 xgui3783 requested a review from apdavison October 27, 2025 15:13
@apdavison
Copy link
Member

Looks good. Is there an easy way to check the tag string conforms to a valid version identifier?

This would allow tags to be used for other purposes, including tagging alpha, beta versions without creating PyPI releases for them.

@xgui3783
Copy link
Collaborator Author

Looks good. Is there an easy way to check the tag string conforms to a valid version identifier?

This would allow tags to be used for other purposes, including tagging alpha, beta versions without creating PyPI releases for them.

I think we can have a validation of the tag, and terminates early if fails.

I will polish this PR a bit, and ping you once ready.

@xgui3783 xgui3783 marked this pull request as draft October 30, 2025 09:17
@xgui3783 xgui3783 marked this pull request as ready for review October 30, 2025 10:00
@xgui3783
Copy link
Collaborator Author

xgui3783 commented Oct 30, 2025

ping @apdavison

can you take a look again? I have added a step which checks the tag matches ^[0-9]+\.[0-9]+\.[0-9]+$

which would allow:

  • 6.1.0

(edited)

@apdavison
Copy link
Member

hi @xgui3783 : I don't think we should publish dev, alpha, beta or rc versions to PyPI

@xgui3783
Copy link
Collaborator Author

good point. updated (up point is regex is also much simper)

@apdavison apdavison merged commit c9821fe into master Oct 30, 2025
3 checks passed
@xgui3783 xgui3783 deleted the cicd_buildrelease branch October 30, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants