add flash heating into slip law#1
Open
Egao0206 wants to merge 14 commits intoHuihuiweng:thermpresfrom
Open
Conversation
Huihuiweng
reviewed
Aug 12, 2024
SRC/bc_dynflt_rsf.f90
Outdated
| end type rsf_type | ||
|
|
||
| public :: rsf_type, rsf_read, rsf_init, rsf_mu, rsf_solver, rsf_qs_solver, rsf_timestep | ||
| public :: rsf_type, rsf_read, rsf_init, rsf_mu, rsf_solver, rsf_qs_solver, rsf_timestep, State_to_theta,Theta_to_state |
Owner
There was a problem hiding this comment.
There is no need to make these two function public, as they are only called within this subroutine.
Huihuiweng
reviewed
Aug 12, 2024
SRC/bc_dynflt_rsf.f90
Outdated
| ! as in Ampuero and Ben-Zion (2008) | ||
| ! 2 = logarithmic rate-and-state with aging state law | ||
| ! 3 = logarithmic rate-and-state with slip state law | ||
| ! 4 = Regularized rate-and-state with slip state law, flash heating(Vw as parameter) |
Owner
There was a problem hiding this comment.
4 is the case with V-shape rate-and-state. You shall use 5 here.
Egao0206
commented
Aug 12, 2024
SRC/bc_dynflt_rsf.f90
Outdated
| endif | ||
| enddo | ||
| Q_ss = f%a * log((2 * f%Vstar / abs(v)) * sinh(mu_ss / f%a)) | ||
| dQ = abs(v)/f%Dc * (Q - Q_ss) |
Author
There was a problem hiding this comment.
Correct: dQ = abs(v) / f%Dc * (Q_ss - Q)
fixed bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regularized RSF (slip law with flash heating) in "bc_dynflt_rsf.f90", where the case is "kind = 5" . However, Compiled successfully, verified failed.