feat(app): switch to better-auth
#696
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for following the naming conventions! 🙏 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a58d2e5b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ? `/auth/${props.provider}?redirect=${encodeURIComponent(props.redirectUrl)}` | ||
| : `/auth/${props.provider}` | ||
| window.location.href = url | ||
| signIn.social({ provider: props.provider }) |
There was a problem hiding this comment.
This change drops the redirect parameter when starting OAuth (signIn.social({ provider })), so users who were sent to /login?redirect=... after hitting a protected page will no longer be returned to their original destination after social auth. The login flow still passes redirect-url into this component, but the prop is no longer read, which is a user-visible regression in navigation behavior.
Useful? React with 👍 / 👎.
apps/shelve/server/db/migrations/postgresql/0003_better_auth.sql
Outdated
Show resolved
Hide resolved
commit: |
…ation # Conflicts: # pnpm-lock.yaml
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9d9ddb9cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { AuthType } from '@types' | ||
| import { userSchema } from '~~/server/db/zod' | ||
|
|
There was a problem hiding this comment.
Removing the legacy OAuth route handlers drops the /auth/{provider} entrypoints, but the invite flow still calls loginWithRedirect with window.location.href = /auth/${provider}?redirect=... in apps/shelve/app/pages/invite/[token].vue. In deployments where Better Auth only serves /api/auth/*, invited users who choose GitHub/Google from the invite screen will hit a missing route and be blocked from accepting invitations unless they switch to email login.
Useful? React with 👍 / 👎.
1 participant
Auth migration to Better Auth.
@onmax/nuxt-better-auth/better-auth.main.Testing:
pnpm typecheck.Notes:
BETTER_AUTH_SECRET; production still should set it.HUB_APPLY_MIGRATIONS_DURING_BUILD=trueto enable).