Skip to content

[fix] In docx whose name is non-ascii, the image url is garbled #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keineahnung2345 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix] In docx whose name is non-ascii, the image url is garbled #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions converters/libre/lib/libre.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def convert

Dir.mktmpdir do |tdir|
user_installation = File.join(tdir, "user_installation")
command(cd + join + soffice( source, user_installation ) + join + move(thisdir(outfile)) )
command(cd + join + soffice( source, user_installation ) )
fix_image_path
command(cd + join + move(thisdir(outfile)) )
end

end #def
Expand All @@ -50,5 +52,17 @@ def soffice( src, user_installation )
"#{LIBRE_OFFICE_BIN} --headless --convert-to #{preview_format} --outdir #{shell_quote tmpdir} -env:UserInstallation=file://#{user_installation} #{shell_quote src}"
end
end #def

def fix_image_path
filepath = Dir[tmpdir+"/*.html"][0]
return if filepath.nil?
basefilename = filepath.split('/')[-1].split('.')[0]
return if basefilename.ascii_only?
if File.exists?(filepath)
text = File.read(filepath)
new_contents = text.gsub(/(?<=img src=")([a-zA-z%\d]+)(?=_html)/, URI::encode_www_form_component(basefilename))
File.open(filepath, "w") {|file| file.puts new_contents }
end
end

end #class
end #class