Fix: Resolve unloadable errors in redmine_more_previews vince converter#109
Open
Bryan0211 wants to merge 4 commits intoHugoHasenbein:mainfrom
Open
Fix: Resolve unloadable errors in redmine_more_previews vince converter#109Bryan0211 wants to merge 4 commits intoHugoHasenbein:mainfrom
unloadable errors in redmine_more_previews vince converter#109Bryan0211 wants to merge 4 commits intoHugoHasenbein:mainfrom
Conversation
The vince converter, used for previewing .vcf vCard files via the VinceLib library, was calling the `unloadable` method. This method was deprecated in Rails 5 and removed in Rails 6. As Redmine 6.0.5 is based on Rails 7.2.2.1, the `unloadable` method is no longer available, leading to a NameError. This commit temporarily disables the vince converter to allow plugin migration and asset precompilation to proceed.
Commented out all instances of the `unloadable` method call from the `vince` converter, a sub-module of the `redmine_more_previews` plugin. The `unloadable` method is deprecated and removed in newer Rails versions (Rails 6+), which caused NameError issues when running Redmine 6.0.X
Commented out all instances of the `unloadable` method call from the `vince` converter, a sub-module of the `redmine_more_previews` plugin. The `unloadable` method is deprecated and removed in newer Rails versions (Rails 6+), which caused NameError issues when running Redmine 6.0.X
…iews into Personal_main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing
NameError: undefined local variable or method 'unloadable'errors encountered when using theredmine_more_previewsplugin (specifically itsvincevCard converter sub-module) with Redmine 6.0.5 (which runs on Rails 7.2.2.1).The
unloadablemethod, previously used for code reloading in older Rails versions, has been removed in Rails 6+ and is incompatible with the Zeitwerk autoloader.This PR removes all instances of the
unloadablecall within thevinceconverter's codebase.Changes Made
unloadablefrom the following files within theredmine_more_previewsplugin inredmine_more_previews/converters/vince/lib/vince_lib