fix: font fallback for deploy, localized og:tags#150
Merged
Conversation
- Graceful font fallback: tries multiple paths (Ubuntu/Fedora/Arch), never crashes on missing fonts - Localized og:title/og:description: uses native-language challenge text from language configs - og:title kept short (e.g. 'Wordle Deutsch — 5/6'), og:description has the full native CTA - Fix unused variable and ternary lint warnings
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR enhances font handling in image generation with a platform-aware resolution mechanism and fallbacks, while updating share metadata in the game template with outcome-specific titles, descriptions, and improved logging. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_share_images.pynow tries multiple font paths (Ubuntu/Fedora/Arch) and never crashes on missing fontsTest plan
pnpm test— all 81 tests passruff format+ruff check— cleanSummary by CodeRabbit
Bug Fixes
New Features