fix: prevent PWA install dialog from auto-showing on page load#141
fix: prevent PWA install dialog from auto-showing on page load#141
Conversation
The @khmyznikov/pwa-install component auto-triggers its own install dialog on page load (via _triggerAppleDialog on iOS, beforeinstallprompt on Android). This is distracting when the user hasn't finished their game yet. Add manual-apple and manual-chrome attributes to suppress auto-display. The dialog is still shown explicitly via showDialog() in our pwa.install() function, which is triggered by the custom banner that only appears after game completion.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo boolean-like attributes ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
@khmyznikov/pwa-installweb component has built-in auto-display behavior that shows an install dialog on page load — independent of our custom banner_triggerAppleDialog()500ms after loadbeforeinstallpromptfiresmanual-appleandmanual-chromeattributes to suppress auto-displayshowDialog()explicitly, so the install flow is unchangedTest plan
Summary by CodeRabbit