Skip to content

Bug fix for Issue #99 maintain correct instance location when locatio… #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffjenk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug fix for Issue #99 maintain correct instance location when locatio… #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb62eab
Bug fix for Issue #99 maintain correct instance location when locatio…
Oct 30, 2015
5d5ace7
Altering bower name and version I cant use this package while waiting…
Oct 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "messenger",
"name": "jeffjenk-messenger",
"repo": "HubSpot/messenger",
"description": "Client-side growl-like notifications with actions and auto-retry.",
"version": "1.4.2",
"version": "1.4.3",
"homepage": "http://github.hubspot.com/messenger",
"authors": [
"Zack Bloom <zackbloom@gmail.com>",
Expand Down
1 change: 1 addition & 0 deletions build/js/messenger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,7 @@ window.Messenger.Events = (function() {
} else if (!$(inst._location).is($(chosen_loc))) {
inst.$el.detach();
$parent.prepend(inst.$el);
inst._location = chosen_loc;
}
}
if (inst._addedClasses != null) {
Expand Down
2 changes: 1 addition & 1 deletion build/js/messenger.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/coffee/messenger.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ window.Messenger._call = (opts) ->

inst.$el.detach()
$parent.prepend inst.$el
inst._location = chosen_loc

if inst._addedClasses?
inst.$el.removeClass inst._addedClasses
Expand Down