fix(eager execution): Fix bug from escaped slash right before quote character#1272
Merged
jasmith-hs merged 1 commit intomasterfrom Nov 18, 2025
Merged
fix(eager execution): Fix bug from escaped slash right before quote character#1272jasmith-hs merged 1 commit intomasterfrom
jasmith-hs merged 1 commit intomasterfrom
Conversation
hs-lsong
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in EagerExpressionResolver that an escaped
\, which should make it innocuous is still being treated as an escape so\\'is being treated as an escaped quote, when it should be a real quote.This is already handled in WhitespaceUtils, and I'm taking that logic of clearing the
prevCharand applying it to the EagerExpressionResolver too