Fix EagerFromTag reconstruction when template file cannot be resolved#1241
Merged
jasmith-hs merged 1 commit intomasterfrom Apr 29, 2025
Merged
Fix EagerFromTag reconstruction when template file cannot be resolved#1241jasmith-hs merged 1 commit intomasterfrom
jasmith-hs merged 1 commit intomasterfrom
Conversation
Makes it more like EagerImportTag's reconstruction logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it more like EagerImportTag's reconstruction logic.
There was a minor bug where the
{% from foo import bar %}token was not marked as a deferred token when it was reconstructed. I made the reconstruction follow the logic that is done forEagerImportTagwhen the template file cannot be reconstructed so it will be marked as a DeferredToken and the set and used variables can be deferred when necessary.