Open
Conversation
kumarashit
reviewed
Aug 30, 2021
| func RemoveNvmeFcDevice(device string) (string, error) { | ||
| var multiPathName string | ||
| var err error | ||
| if strings.HasPrefix(device, "dm") { |
There was a problem hiding this comment.
This is valid only for DM multipath. If other multipath like Ultrapath or EMCPP comes then we will have to put other checks
| // devices: nvme0n1, nvme2n1, | ||
| _, err = getDeviceFromDM(multiPathName) | ||
| if err != nil { | ||
| log.Warningf("Get the devices from the multipath %s error: %v", multiPathName, err) |
There was a problem hiding this comment.
As this is just warning, this means the sys class has issues and we are ignoring it. Further when you try to flush the device without having the sysfs entries, will it create issues?
| return err | ||
| } | ||
|
|
||
| if multiPathName != "" { |
There was a problem hiding this comment.
If this is multipath device, then the device flush attempt has already been done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the changes required in current code base to support NVMe over FC protocol.
Current framework already has code to handle some part of the support
Unit test to be added to this PR
Key scenarios tested:
Volume create/delete
POD create/delete
Volume expand
Volume clone
Volume snapshot
Support DM multipath and single path
Data write on pvc
Node restart scenarios