feat: updated filters for campaigns discovery#836
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Campaign Launcher server’s campaign discovery endpoint to support additional filtering (by campaign type and exchange) and aligns the subgraph client dependency with the required schema/fields.
Changes:
- Add
typeandexchangefilters to the campaigns discovery API (controller → service → subgraph query). - Extend campaign response data with
cancellationRequestedAt. - Bump
@hu-fi/subgraph-sdkto3.0.0-beta.4.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| campaign-launcher/server/src/modules/campaigns/campaigns.dto.ts | Adds new query params (type, exchange) and adds cancellationRequestedAt to the campaign DTO. |
| campaign-launcher/server/src/modules/campaigns/campaigns.controller.ts | Wires new query params into the service filter object. |
| campaign-launcher/server/src/modules/campaigns/campaigns.service.ts | Passes new type_in / exchange_in filters to the subgraph and maps cancellationRequestedAt. |
| campaign-launcher/server/package.json | Updates @hu-fi/subgraph-sdk dependency version. |
| campaign-launcher/server/yarn.lock | Locks updated @hu-fi/subgraph-sdk resolution/checksum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
To close #834
Context behind the change
@hu-fi/subgraph-sdkHow has this been tested?
Release plan
Regular release
Potential risks; What to monitor; Rollback plan
N/A