Add addPolicyName/removePolicyName methods for TrustedTypesDirective

[sideshowbarker]

Summary

• Port the remaining manipulation API from Add trusted-types and require-trusted-types-for CSP directives shapesecurity/salvation#273 that was not included in 34b5635
• Add ManipulationErrorConsumer interface and removeValueExact() to Directive base class
• Add addPolicyName() and removePolicyName() to TrustedTypesDirective
• Add 8 new tests covering validation, duplicate warnings, case sensitivity, special characters, round-trip serialization, and edge cases

[kingthorin]

I'm not against these methods but if I recall correctly all the manipulation functionality was removed when the library was brought into this repo.

[sideshowbarker]

I'm not against these methods but if I recall correctly all the manipulation functionality was removed when the library was brought into this repo.

Ah OK — well, if the manipulation functionality was intentionally removed, then I don’t feel strongly about adding it back. And in that case, we could just close this unmerged. I don’t need that functionality for the HTML checker, and I don’t personally have any other use cases for it. I had raised this only in a kind of due-diligence spirit of having the patch check off all the boxes only being complete as I could make it. But it seems like we don’t need for it be quite so “complete”…

[rbri]

but if I recall correctly all the manipulation functionality was removed when the library was brought into this repo.

The readme also states this

For HtmlUnit, the code has been adapted to the code style rules used, and support for editing policies has been removed.

Removing the edit part makes maintenance a bit simpler and as long as noone needs this I like to stay with this.

❤️ cool to have you on board @sideshowbarker, thanks!

[sideshowbarker]

Removing the edit part makes maintenance a bit simpler and as long as noone needs this I like to stay with this.

OK, then I’ll go ahead and close this.

❤️ cool to have you on board @sideshowbarker, thanks!

Cheers~ Excited to be here 😄