Skip to content

Conversation

@DemitryVolovich
Copy link

@DemitryVolovich DemitryVolovich commented Jan 2, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

swarthy and others added 30 commits June 2, 2020 14:07
…es (sequelize#12420)

This will allow changeColumn/renameColumn/removeColumn to preserve constraints and references
sdepold and others added 24 commits November 8, 2021 10:16
* fix: expect result is null but got zero

* revert: query-interface.js

* fix: model.js to return null

* fix: test title

* fix: if sum without rows, expect null

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Patch with missing type definitions for static decrement method

Co-authored-by: Constantin Metz <58604248+Keimeno@users.noreply.github.com>
Co-authored-by: ᛜ ᛝᛉᚲ <fncolon@pm.me>
Co-authored-by: sander-mol <SMol@thepeoplegroup.nl>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
…quelize#13481)

* Update operators.d.ts

resolved the typescript issue for Op.match (sequelize#12955)

* Update operators.d.ts

Co-authored-by: Constantin Metz <58604248+Keimeno@users.noreply.github.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
This does require maintainers/issue reviewers to add type labels to all still occurring issues and regularly update them
* fix(mssql): sqlserver 2008 fix for using offsets and include criteria

* fix(mssql): sqlserver 2008 fix for using offsets and include criteria

* fix(mssql): sqlserver 2008 fix for using offsets and include criteria

* fix(mssql): sqlserver 2008 fix for using offsets and include criteria

Co-authored-by: sschwenker <sschwenker@inmoment.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Co-authored-by: ᛜ ᛝᛉᚲ <fncolon@pm.me>
* fix: typing on creation within an association

* fix: tests

Signed-off-by: Mohamed El Mahallawy <mmahalwy@gmail.com>
…ize#13673)

This commit uses the pg_connection_string package to parse the
connection string if the dialect is postgresql. This is helpful because
it automatically handles reading SSL certs that are specified in the
connection string.

As part of this, support was added for the `options` URL parameter,
which allows arbitrary session variables to be configured in the
connection string.

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
* feat: option for attributes having dotnotation

- `options.dotnotation`, can be used when the column name has dot in it.

* test: add test case for attributes with dot notation

* docs: add function doc for `option.dotnotation`

* fix: expected query for dot notation test case

* refactor: camelcase dotnotation keyword

Co-authored-by: Mukesh Suthar <mukesh@stepsetgo.com>
@DemitryVolovich DemitryVolovich marked this pull request as ready for review January 2, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.